OnBoard interview question

(In response to the code project) How would you do this better?